Re: mingw build failure

[Michael Goffioul]

On Sun, Dec 1, 2013 at 9:08 AM, John D <address@hidden> wrote:

 

 

From: Michael Goffioul [mailto:address@hidden]
Sent: Saturday, November 30, 2013 9:21 PM
To: John D
Cc: Octave Maintainers List
Subject: Re: mingw build failure

 

On Sat, Nov 30, 2013 at 8:14 PM, John D <address@hidden> wrote:

I decided to do a complete native rebuild of octave  id=132667955f66 and it
fails:

../../libinterp/dldfcn/__init_fltk__.cc: In member function 'void
fltk_uimenu::u
pdate_foregroundcolor(uimenu::properties&)':
../../libinterp/dldfcn/__init_fltk__.cc:482:43: error: 'gnulib' has not been
dec lared
../../libinterp/dldfcn/__init_fltk__.cc:483:43: error: 'gnulib' has not been
dec lared
../../libinterp/dldfcn/__init_fltk__.cc:484:43: error: 'gnulib' has not been
dec lared
make[3]: *** [dldfcn/dldfcn___init_fltk___la-__init_fltk__.lo] Error 1


Going back to previous versions that used to compile (although I probably
hadn't done a complete rebuild at that time) do the same thing.

Anyone else done a recent complete native mingw build and seen the same
issue?

 

This looks pretty similar to the problem I had with MSVC and I reported here [1]. I ended up reverting the changeset [2] locally.

 

[1] http://octave.1599824.n4.nabble.com/Order-of-AM-CPPFLAGS-and-other-xxx-CFLAGS-td4659194.html

[2] http://hg.savannah.gnu.org/hgweb/octave/rev/a230b996ae8a

 

 

Reverting that patch fixed that issue and then it started to complain in libgui:

 

../../libgui/src/thread-manager.cc: In static member function 'static void octave_thread_manager::block_interrupt_signal()':

../../libgui/src/thread-manager.cc:126:28: error: 'SIG_BLOCK' was not declared in this scope

../../libgui/src/thread-manager.cc: In static member function 'static void octave_thread_manager::unblock_interrupt_signal()':

../../libgui/src/thread-manager.cc:132:28: error: 'SIG_UNBLOCK' was not declared in this scope

make[3]: *** [src/src_libgui_src_la-thread-manager.lo] Error 1

I'm not having that issue with MSVC, but I'd say this might be the same cause as the previous problem: that is some "standard" include directory appears before the gnulib's one, so you end up including the regular version of the header instead of gnulib's replacement. Inspect your compile command line and the order of the "-I..." flags.

Michael.