octave-maintainers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: configure.ac and Dolfin.h


From: c.
Subject: Re: configure.ac and Dolfin.h
Date: Wed, 5 Mar 2014 08:51:23 +0100

On 5 Mar 2014, at 02:50, Eugenio Gianniti <address@hidden> wrote:

> I prepared a patch, that I hereby attach, to address the issue. Currently I 
> can’t test it because the version of FEniCS I installed crashes python, 
> leading to the failure of the build. Anyway, since the problem is related to 
> the flags passed to mkoctfile and those rules work for me, I would ask you to 
> try to apply the patch and build to test it.
> 

Eugenio,

If you wish to work on a project about fem-fenics, I think the first step
for you should be to get it to work on your system.

For this particular patch, which is about making the package installation 
easier,
I think it is even more important to do so.

What use is a build system patch if it does not even work for you wh wrote it?

So I would suggest to take a step back and look at the project in perspective
considering the task you want to accomplish before delving deep into the 
technical 
details.

So, what are the installation problems you see on your system?
What needs to be done to fix them?
What, in your opinion, would need to be done to make the installation 
experience less frustrating and more straightforward for the general user?

By discussing these issues on the list and proposing solutions I think
you would show your ability to carry out the proposed project much better
than by submitting an unested half-baked patch.

Now, as for the details of your changeset:

* src/AUTHORS src/COPYING src/ChangeLog src/INSTALL src/NEWS src/README:
     Added to comply with Automake requirements. They are either empty or
     the default ones.

This is nonstandard and somewhat ugly, according to the guidelines for creating
Octave Forge packages these files should reside in the package root and not in 
the src 
subdirectory.

Before choosing to do similar nonstandard hacks you should ask other developers
if there is any other option and check what is done in other packages..

Don't be shy to ask questions and to interact with the community, your 
willingness 
and ability to do so is one of the key elements in making your application 
successful.

HTH
c.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]