Re: Package for level-set method?

[Juan Pablo Carbajal]

On Fri, May 9, 2014 at 8:25 AM, Daniel Kraft <address@hidden> wrote:
> Hi!
>
> On 2014-05-09 01:43, Juan Pablo Carbajal wrote:
>> The package looks good. I think when you have polish it a little bit
>> (see below) is ready to be integrated into Octave Forge (@Carnë?)
>
> Thank you very much for taking a look!
>
> It would be great to have it in Octave Forge -- there are still some
> things I want to improve over time (in particular, adding mesh building
> capabilities), but I'd prefer to get it into Octave Forge as soon as
> possible and then develop there further.
>
>> Here my observations
>> - What is __levelset_getdir.m for? If it is a private function you
>> should install it inside the private folder.
>
> It is a private function, but it is used in a demo.  (To locate the
> "maze.png" file.)  As such, I think I can not move it to "private/",
> since this seems not to be accessible from demos.  I found no better way
> of locating the image file from within the demo, but if you have
> suggestions, I'm open to change this.
>

If it is a private function, why is a demo trying to call it directly?
A private function should be called only from within other functions.
Do you mean that functions cannot reach it?


>> - The scripts in the repository demoAll and testAll fail in several
>> cases. Some demos and tests cant find the functions geomElements,
>> internal_init_narrowband and internal_fastmarching. I guess is just
>> old names for functions you have in your package.
>
> These functions should all be provided by the .oct files in src.  Did
> you build them before running the demoAll and testAll scripts?
>
> A single test is currently xfail'ed (related to the first issue in the
> TODO file), but this is not a defect with respect to the functionality.
>  (Rather, a temporary and undocumented extension which I need to work
> around the problem in my own codes until I find the time to properly
> improve the code in the package to make the workaround unnecessary.)
> Everything else should work and all tests succeed.
>
I run "build.sh"  this created a tar file that I installed using
"pkg". The compilation should be taken care by the Makefile.
The problem is that your Makefile interferes with pkg install.
>From the phony argument "oct" remove all commands. That is you should have
oct: $(OCT_FILES)

and nothing else. The compiled functions do not go to "private" they
receive their own architecture dependent folder.
Also remove the file FILES from the src folder.

This made a correct installation of your package and everything works fine.

> Yours,
> Daniel
>
> --
> http://www.domob.eu/
> OpenPGP: 901C 5216 0537 1D2A F071  5A0E 4D94 6EED 04F7 CF52
> Namecoin: id/domob -> https://nameid.org/?name=domob
> --
> Done:  Arc-Bar-Cav-Hea-Kni-Ran-Rog-Sam-Tou-Val-Wiz
> To go: Mon-Pri
>