octave-maintainers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [fem-fenics] ufl.m


From: Marco Vassallo
Subject: Re: [fem-fenics] ufl.m
Date: Wed, 21 May 2014 15:53:42 +0200




On Wed, May 21, 2014 at 2:58 PM, Eugenio Gianniti <address@hidden> wrote:
Dear Marco, and all,

I attach the ufl.m function I have previously mentioned for review.

Thanks, really good job.
 
I still have to edit something, namely on line 45 a check for the .ufl file extension is performed with a case insensitive matching, but I should ensure with a couple more instructions that the lower case version is used, as in the functions that compile the .oct files for the problem at hand.

You should also check that we are not overwriting an existing file.
 
There is also an issue due to a bug present in the stable version currently distributed, but solved in the development version. I also attach script.m, containing basically the Poisson.ufl of the homonymous example, but with ufl in first position. I noticed that my function works as I expect with the simpler lines, but Octave errors out when trying to execute the second and the ninth (I added comments to highlight those lines). This happens only in the stable release, on the other hand the development version goes on without complaining. Here is the error:

>> script
parse error near line 2 of file /Users/eugenio/tests/script.m

  syntax error

>>> ufl element = FiniteElement("Lagrange", triangle, 1)

How should I proceed with respect to this behaviour?

I don't have the stable version so I don't know how to reproduce it.
However it could be the "," as it is present only in this two lines.
But, as it has been fixed in the development version, probably someone here in the list can explain this behavior. 

Marco
Eugenio



reply via email to

[Prev in Thread] Current Thread [Next in Thread]