Re: Trouble compiling gui-release branch

[Torsten]

On 23.06.2014 22:58, Rik wrote:
> 6/23/14
> 
> Torsten,
> 
> I'm no longer able to compile the gui-release branch after this changeset:
> 
> changeset:   18854:0a66861d8069
> branch:      gui-release
> tag:         tip
> parent:      18848:b314efd58072
> user:        Torsten <address@hidden>
> date:        Sun Jun 22 15:42:00 2014 +0200
> summary:     implementation of search in selection in gui editor (bbug #41196)
> 
> The error I get is
> 
> make[2]: Entering directory `/home/rik/wip/Projects_Mine/octave-gui/src'
> /bin/bash ../libtool  --tag=CXX   --mode=link g++  -Wall -W -Wshadow
> -Wold-style-cast -Wformat -Wpointer-arith -Wwrite-strings -Wcast-align
> -Wcast-qual -O2 -pipe -pthread -no-undefined   -o octave-gui
> octave_gui-main-gui.o ../libgui/liboctgui.la ../libinterp/liboctinterp.la
> ../liboctave/liboctave.la  -lutil -lm 
> libtool: link: g++ -Wall -W -Wshadow -Wold-style-cast -Wformat
> -Wpointer-arith -Wwrite-strings -Wcast-align -Wcast-qual -O2 -pipe -pthread
> -o .libs/octave-gui octave_gui-main-gui.o  ../libgui/.libs/liboctgui.so
> ../libinterp/.libs/liboctinterp.so ../liboctave/.libs/liboctave.so -lutil
> -lm -pthread -Wl,-rpath -Wl,/home/rik/downloads/local/lib/octave/3.9.0+
> ../libgui/.libs/liboctgui.so: undefined reference to
> `find_dialog::handle_sel_search_changed(int)'
> ../libgui/.libs/liboctgui.so: undefined reference to
> `find_dialog::handle_selection_changed(bool)'
> collect2: ld returned 1 exit status
> 
> The problem seems to be that in the file find-dialog.cc the two functions
> are protected by an #ifdef.
> 
> #ifdef
> void
> find_dialog::handle_sel_search_changed (int selected)
> {
>   _from_start_check_box->setEnabled (! selected);
>   _find_result_available = false;
> }
> 
> void
> find_dialog::handle_selection_changed (bool has_selected)
> {
>   if (_rep_active)
>     return;
> 
>   _search_selection_check_box->setEnabled (has_selected);
>   _find_result_available = false;
>   if (! has_selected)
>     _search_selection_check_box->setChecked (false);
> }
> #endif
> 
> If I check my config.h I find that HAVE_QSCI_FINDSELECTION is not set so
> these functions are not defined.  I'm sure you had an idea about what
> should happen in this case.  Should the routines be commented out in the
> header file find-dialog.h as well?

Yes, I have already pushed changeset
http://hg.savannah.gnu.org/hgweb/octave/rev/fc0f3b6c37a9
to fix this issue.

Torsten