RE: Octave 3.8.2-rc2 release candidate available for ftp - x11 error

[John D]

-----Original Message-----
From: Philip Nienhuis [mailto:address@hidden 
Sent: Saturday, July 05, 2014 9:33 AM
To: John Donoghue; address@hidden
Subject: Re: Octave 3.8.2-rc2 release candidate available for ftp - x11
error

John Donoghue wrote:
> On 07/04/2014 05:57 PM, Philip Nienhuis wrote:
>> John Donoghue wrote:

<long snip>

>>> - Add a "--with-x=no" flag to the configure options in 
>>> src/stable-octave.mk (& src/octave.mk) to ensure gl2ps is included 
>>> in the build (had to do it even with latest mxe-octave checkout) 
>>> (thanks John D for the hint)
>>
>> Ah thanks. So my feeling I hit this before was justified :-)
>>
>> OK I found that post now - google didn't turn it up for me, nor 
>> nabble's search (I looked for octave + Xlib).  Did you convey that 
>> hint through private communication? can't find it in my mail archive 
>> either.
>>
>> Anyway shouldn't this fix be pushed to mxe-octave, please?
>>
>> Philip
>>
>>
>>
> I could add something to octave.mk like:
> ifeq ($(MXE_SYSTEM),mingw)
>    $(PKG)_EXTRA_CONFIGURE_OPTIONS += --with-x=no endif

I think that would do fine. I find it hard to imagine anyone building Octave
for Windows outside MXE, so from a practical POV this would cover building
for Windows.

Would it hurt to do both? i.e., combine it with the other option:

> But would it be better long wrong to not check for X if we are a ms 
> windows system? ie: in configure:
 >
> --- a/configure.ac      Fri Jul 04 20:22:58 2014 -0400
> +++ b/configure.ac      Fri Jul 04 20:24:58 2014 -0400
> @@ -1070,8 +1070,13 @@
>   AC_SUBST(MAGICK_LIBS)
>
>   ### Check for X11 libraries
> -
> -AC_PATH_X
> +case $host_os in
> +  mingw* | msdosmsvc)
> +  ;;
> +  *)
> +    AC_PATH_X
> +  ;;
> +esac
>   if test "$have_x" = yes; then
>     AC_DEFINE(HAVE_X_WINDOWS, 1, [Define to 1 if you have X11.])

N.B.: (pardon my configure ignorance) doesn't cygwin use X? or is that
covered here? How about building only a CLI?

Philip


---

Example just checked for msvc and mingw and didn't attempt to look for X in
that case - Cygwin should remain unaffected.
For now, I will push the --no-x option on mxe.