octave-maintainers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

tests in private m-scripts


From: Andreas Weber
Subject: tests in private m-scripts
Date: Fri, 18 Jul 2014 17:32:36 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Icedove/24.5.0

Hi Rik.

While digging into the fltk plotting routines I found a note from you
(http://hg.savannah.gnu.org/hgweb/octave/rev/12793):

## Test blocks are not allowed (and not needed) for private functions
and the following tests in
scripts/plot/util/private/__print_parse_opts__.m are disables with #%!test.

I read the tests to understand the usage of __print_parse_opts__ but
figured soon out that some tests nowadays fails with default or
3.8.2-rc2. For example

octave:1> test __print_parse_opts__
  ***** test
 opts = __print_parse_opts__ ("test.pdf", "-S640,480");
 assert (opts.canvas_size, [307.2, 230.4], 0.1);
!!!!! test failed
ASSERT errors for:  assert (opts.canvas_size,[307.2, 230.4],0.1)

  Location  |  Observed  |  Expected  |  Reason
    (1)          640         307.2       Abs err 332.8 exceeds tol 0.1
    (2)          480         230.4       Abs err 249.6 exceeds tol 0.1


Should we simply remove the disabled tests or is it worth fix them (I
bet the weren't run for years)? Just keep them as they are is IMHO
confusing other who try to understand the code.

-- Andy



reply via email to

[Prev in Thread] Current Thread [Next in Thread]