octave-maintainers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: inpolyeder


From: Carnë Draug
Subject: Re: inpolyeder
Date: Wed, 10 Sep 2014 22:41:20 +0100

On 5 September 2014 21:06, Cumbiambero <address@hidden> wrote:
>
> El 05/09/14 a las #4, Juan Pablo Carbajal escribió:
>
>> On Fri, Sep 5, 2014 at 7:31 PM, Carnë Draug <address@hidden> wrote:
>>>
>>> On 2 September 2014 20:17, Cumbiambero <address@hidden> wrote:
>>>>
>>>> I would like to share my inpolyeder function that is used to tell if a
>>>> point
>>>> is inside, on or outside of a given polyeder, similar to the inpolygon
>>>> function but for 3 dimensions.
>>>>
>>>> My sourceforge-username is: cumbiambero
>>>
>>> Hi
>>>
>>> I'm guessing you are trying to contribute the function to the Octave
>>> Forge geometry package? We no longer give people commit access to the
>>> Octave Forge repositories (except after many contributions). We have
>>> moved from svn to mercurial which is a distributed version control
>>> system. This means you can clone the repository to your system, commit
>>> to it and either:
>>>
>>> 1) send us changesets that we can import and push to our repositories;
>>> 2) host your clone somewhere and we can pull your changes from there.
>>>
>>> Either way, you can note them on the Octave patch tracker [1].
>>>
>>> But rather than make another function that is very similar to the
>>> existing one for cases when there's another dimension, why not extend
>>> the current one? If inpolygon() is currently:
>>>
>>>    inpolygon (X, Y, xv, yv)
>>>
>>> does
>>>
>>>    inpolygon (X, Y, Z, xv, yv, zv)
>>>
>>> make any sense? And If you're extending it so it handles one more
>>> dimension, why not make it for any number of dimensions? I've seen it
>>> happen many times in image processing, and people end up with things
>>> such as erode, erode3d, erode3dtime, erode5d, etc, and it's all the
>>> same thing if they had just made it for N dimensions. Does
>>>
>>>    inpolygon (X, Y, Z, ..., N, xv, yv, zv, ... nv)
>>>
>>> make any sense?
>>>
>>> Carnë
>>>
>>> [1] https://savannah.gnu.org/patch/?func=additem&group=octave
>>>
>> The function can be a nice addition to the geometry package. do you
>> have an example of your code?
>
> Hi Juan Pablo, Hi Carnë,
>
> I send you a zip file containing all the code and documentation. It was part
> of an academic project when I did my bachelor degree two years ago.
> You can use it if you like. Most of the documentation is in german. The
> inPolyederTest.m file is an example of the usage.
>
> I'm not sure if it can be easily extended to more than 3 dimensions. I guess
> it's not that easy.
>
> Have a nice weekend!
>
> Eduardo

Hi

please always include the mailing list when replying so that other interested people can also reply. A couple of things:

1) you do not specify the license of your code. Without a specific license, it cannot be included into Octave or Octave Forge. But you claim that the code is based on Octave's inpolygon(). If it's derivative work, I believe you're stuck with GPLv3+.

2) can you please upload such thing to the patch tracker? [1] This sort of things get lost very quickly on the mailing list.

Carnë

Attachment: InPolyeder.zip
Description: Zip archive


reply via email to

[Prev in Thread] Current Thread [Next in Thread]