Re: Some M core functions

[Fotios Kasolis]

On 2014-09-23 15:01, Carnë Draug wrote:
> On 23 September 2014 10:53, Fotios Kasolis <address@hidden> wrote:
> > non linear least squares bounds octaveDear maintainers,
> >
> > this mail includes implementations of the address@hidden@b core functions:
> >
> > isdiag, istril, istriu, isbanded, bandwidth
> >
> > that i could not find info here http://hg.savannah.gnu.org/hgweb/octave/
> > After checking them, feel free to use them.
> Could you please submit these to the patch tracker [1]? This sort of
> things get lost very easily on the mailing list.
>
> You can probably replace most of isdiag() with "istriu (A) && istril
> (A)" rather than duplicate the content of those functions.
>
> Also, I think there's no problem with typing the word Matlab. As far
> as I know, they haven't put a taboo curse on the name of the product
> and even if they did, I'm not sure if it is triggered by written form.
>
> Carnë
>
> [1] https://savannah.gnu.org/patch/?func=additem&group=octave

Done! to patch tracker.

Indeed you can replace the parts you mention with istriu and istril, but 
I found it clearer since the actual
implementation is tiny and at the same time you avoid checking input 
once more, which
yesterday night I found unnecessary. Feel free to adjust accordingly.

I guess you are right regarding address@hidden@b, it is more a matter of personal 
convention rather than a regulation
issue.

Enjoy,
/Fotis