Re: Problem in parse-tree/lex.ll when make-checking

[Pantxo]

Le 07/03/2015 18:16, Rik-4 [via Octave] a écrit :

On 03/07/2015 08:01 AM, [hidden email] wrote:
> Subject:
> Re: Problem in parse-tree/lex.ll when make-checking
> From:
> Pantxo [hidden email]
> Date:
> 03/07/2015 07:43 AM
> To:
> [hidden email]
> List-Post:
> [hidden email]
> Content-Transfer-Encoding:
> quoted-printable
> Precedence:
> list
> MIME-Version:
> 1.0
> References:
> [hidden email] [hidden email] [hidden email] [hidden email] [hidden email] [hidden email]
> In-Reply-To:
> [hidden email]
> Message-ID:
> [hidden email]
> Content-Type:
> text/plain; charset=UTF-8
> Message:
> 3
>
> Julien Bect-2 wrote
>> > Le 05/03/2015 08:35, Julien Bect a écrit :
>>> >> [...]
>>> >>
>>> >> Ok, I think I have found it. The test is attached.
>> >
>> > Oooops, sorry, I forgot the attachment. But you can see the test in the
>> > mail anyway.
>> >
>>> >> # ./run-octave --no-gui
>>> >>
>>> >> [...]
>>> >>
>>> >> parse-tree/lex.ll :2697 : void octave_base_lexer::handle_number():
>>> >> l'assertion « nread == 1 » a échoué.
>>> >> panic: Abandon -- stopping myself...
>>> >> Abandon (core dumped)
>> >
>> > One more detail : I first ran into this problem while running "make
>> > check" as root.
>> >
>> > The isolated failure reported in my previous email was also obtained
>> > while running as root.
>> >
>> > If I run the same test as an ordinary user, I don't see the failure any
>> > more.
>> >
>> > HTH...
> A bug report on this issue has been filed [1]. As the reporter also had
> non-english locale, I tried myself and found that the segfault disappeared
> if I first set LC_NUMERIC to "en_US".
> @Julien: Do your root and normal user accounts have different locales ?
>
> Pantxo
>
> [1] https://savannah.gnu.org/bugs/index.php?44469

Pantxo,

I think we may have been through this cycle once before.  I remember experiments with what Matlab does and it apparently sets LC_NUMERIC to 'C' regardless of the current locale.  We copied this behavior in octave.cc.

-- Code --
octave_initialize_interpreter (int argc, char **argv, int embedded)
{
  // Matlab uses "C" locale for LC_NUMERIC class regardless of local setting
  setlocale (LC_NUMERIC, "C");
  setlocale (LC_TIME, "C");
-- End Code --

As a first check, could you try setting LC_NUMERIC to "C" instead of "en_US" and see if the tests still pass?

If that passes, then I think the problem is why LC_NUMERIC is not being set.  Maybe this is related to the fact that octave is now just a dispatcher to octave-cli and octave-gui.  Perhaps because we do an exec, rather than a fork, some aspects of the environment are not transferred to the subsidiary process.  Just guessing, I could be completely wrong here.

--Rik

---

If you reply to this email, your message will be added to the discussion below:

http://octave.1599824.n4.nabble.com/Problem-in-parse-tree-lex-ll-when-make-checking-tp4668912p4669035.html

To unsubscribe from Problem in parse-tree/lex.ll when make-checking, click here.
NAML

    Rik,
    
    H.G. Hardy did test the C locale and it also avoids triggering the
    segfault (see comment #4 in bug #44469). 
    
    We also discussed this problem with setlocale in bug #44029. I
    posted there a C++ oct file that lets you see at run-time the locale
    that Octave is currently using. Oddly enough, the returned value for
    "setlocale (LC_ALL, NULL)" is not consistent over Octave sessions :
    
    * sometimes I get the full list of LC_XXX with their value. In that
    case LC_NUMERIC is right, i.e. "C"
    * sometimes I get only what looks like the value of LC_LANG:
    "fr_FR.UTF-8". Then if I try to play with printf family of functions
    in Octave, I can see the decimal separator is comma. 
    
    I didn't look into  "make check" rules but I suppose we currently
    use the Qt-cli environement to run tests right? At least bug #44469
    only happens when we use 2 threads, so thread-safety of locales is
    probably worth investigating.  
    
    Pantxo

---

View this message in context: Re: Problem in parse-tree/lex.ll when make-checking
Sent from the Octave - Maintainers mailing list archive at Nabble.com.