Re: Better icons for toolbar

[rik]

On 04/01/2015 11:26 AM, address@hidden wrote:

Subject:

Re: Missing translations of Qt figure toolbar / Toolbar Icons

From:

Mike Miller <address@hidden>

Date:

04/01/2015 11:26 AM

To:

rik <address@hidden>

CC:

Octave Maintainers <address@hidden>

List-Post:

<mailto:address@hidden>

Precedence:

list

MIME-Version:

1.0

References:

<address@hidden> <address@hidden>

In-Reply-To:

<address@hidden>

Message-ID:

<address@hidden>

Content-Type:

text/plain; charset=UTF-8

Message:

5

On Wed, Apr 1, 2015 at 11:16:04 -0700, Rik wrote:

> And as long as we're in this part of the code, is there a reason we don't
> have cute icons for "Axes", "Grid", and "Autoscale"?

That was last discussed and left hanging here, AFAICT:

http://octave.1599824.n4.nabble.com/Hi-Resolution-Icons-tp4668592p4669194.html

The patch mentioned at the end of the discussion (https://savannah.gnu.org/patch/index.php?8614) was applied March 4th, or about three weeks ago.  I think maybe something else has to happen.

The code is in libgui/graphics/Figure.cc:  As an example

  QAction *toggle_axes = m_figureToolBar->addAction (tr ("Axes"));
  connect (toggle_axes, SIGNAL (triggered (void)),
           this, SLOT (toggleAxes (void)));

My guess is that "Axes" isn't like "File" or "Save" for which there is a default icon and so we might have to explicitly set the icon.

--Rik