[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Octave Forge] [Patch] Remove OCTAVE_ALLOCATOR macros in fem-fenics
From: |
Mike Miller |
Subject: |
Re: [Octave Forge] [Patch] Remove OCTAVE_ALLOCATOR macros in fem-fenics |
Date: |
Wed, 8 Apr 2015 09:21:17 -0400 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Wed, Apr 08, 2015 at 12:20:02 +0000, Eugenio Gianniti wrote:
> I’ve never really caught the role of those macros, but for backward
> compatibility it might be better to check the version of Octave
> fem-fenics is being compiled against in the configure script, then
> remove the macros based on this information, or leave them in place
> and define an empty macro to make the compiler happy. I guess the best
> approach is to do as other maintainers did in their packages. What is
> the common practice in this matter?
Here's what I did:
http://hg.code.sf.net/p/octave/communications/rev/dd3e0dc1cd05
HTH,
--
mike