Re: Increasing tolerance for lscov

[Rik]

On 11/24/2015 07:07 AM, address@hidden wrote:

Subject:

Re: Octave 4.0.0 release candidate 2 available for ftp

From:

Doug Stewart <address@hidden>

Date:

11/23/2015 06:44 PM

To:

Chechu Garguez <address@hidden>

CC:

Octave Maintainers List <address@hidden>

List-Post:

<mailto:address@hidden>

Precedence:

list

MIME-Version:

1.0

References:

<address@hidden> <address@hidden> <address@hidden> <address@hidden>

In-Reply-To:

<address@hidden>

Message-ID:

<address@hidden>

Content-Type:

multipart/mixed; boundary=047d7bb04d62b040b605254053e5

Message:

2

On Thu, Apr 2, 2015 at 3:27 AM, Chechu Garguez <address@hidden> wrote:

Good morning,

We were after testing Octave 4.0.0 rc2 on debian testing Jessie, next stable.

It works almost fine except , it fails at lscov test; as in ubuntu 15.04

32bit standard build

openblas

llvm-3.1

c++11 standard

----

Summary:

  PASS     12883
  FAIL         1
  XFAIL       15
  SKIPPED     20

Details of FAIL

>>>>> processing /mnt/extra1/octave-4.0.0-rc2/scripts/statistics/base/lscov.m
***** test
 ## Adapted from example in Matlab documentation
 x1 = [.2 .5 .6 .8 1.0 1.1]';
 x2 = [.1 .3 .4 .9 1.1 1.4]';
 X = [ones(size(x1)) x1 x2];
 y = [.17 .26 .28 .23 .27 .34]';
 [b, se_b, mse, S] = lscov(X, y);
 assert(b, [0.1203 0.3284 -0.1312]', 1E-4);
 assert(se_b, [0.0643 0.2267 0.1488]', 1E-4);
 assert(mse, 0.0015, 1E-4);
 assert(S, [0.0041 -0.0130 0.0075; -0.0130 0.0514 -0.0328; 0.0075 -0.0328 0.0221], 1E-4);
 w = [1 1 1 1 1 .1]';
 [bw, sew_b, msew] = lscov (X, y, w);
 assert(bw, [0.1046 0.4614 -0.2621]', 1E-4);
 assert(sew_b, [0.0309 0.1152 0.0814]', 1E-4);
 assert(msew, 3.4741e-004, -1E-4);
 V = .2*ones(length(x1)) + .8*diag(ones(size(x1)));
 [bg, sew_b, mseg] = lscov (X, y, V);
 assert(bg, [0.1203 0.3284 -0.1312]', 1E-4);
 assert(sew_b, [0.0672 0.2267 0.1488]', 1E-4);
 assert(mseg, 0.0019, 1E-4);
 y2 = [y 2*y];
 [b2, se_b2, mse2, S2] = lscov (X, y2);
 assert(b2, [b 2*b], eps)
 assert(se_b2, [se_b 2*se_b], eps)
 assert(mse2, [mse 4*mse], eps)
 assert(S2(:, :, 1), S, eps)
 assert(S2(:, :, 2), 4*S, eps)
!!!!! test failed
ASSERT errors for:  assert (b2,[b, 2 * b],eps)

  Location  |  Observed  |  Expected  |  Reason
   (3,2)       -0.2624      -0.2624      Abs err 2.7756e-16 exceeds tol 2.2204e-16

Attached is a patch to fix this.

Doug,

I increased the tolerance to 2*eps on the stable branch here http://hg.savannah.gnu.org/hgweb/octave/rev/a0655d18c9cc.

--Rik