Re: Default does not compile anymore on Mac OS

[John W. Eaton]

On 12/19/2015 06:19 AM, Ben Abbott wrote:
> > On Dec 19, 2015, at 05:55, Sebastian Schöps <address@hidden> wrote:
> >
> > Dear all,
> >
> > I cannot compile the default branch anymore (Mac OS X 10.11.3, Xcode 7.2). I
> > am not sure if this is due to changes of Apple or in Octave. Any ideas?
> >
> > > /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.11.sdk/usr/include/mach/mach.h:86:15:
> > error: declaration of 'panic' has a different language linkage
> > > extern void                     panic(const char *, ...);
> > >                                ^
> > > libinterp/corefcn/error.h:103:27: note: previous declaration is here
> > > extern OCTINTERP_API void panic (const char *fmt, ...) GCC_ATTR_NORETURN;
> > >                          ^
> > > 1 error generated.
> > > make[2]: *** [libinterp/corefcn/libinterp_corefcn_libcorefcn_la-display.lo]
> > Error 1
> >
> > Bye
> > Sebastian
>
> The offending change is 58263bea2fdf. You should be able to build again after 
> ...
>
> hg update 58263bea2fdf
>
> But I think that implies subsequent changesets are not present.

I think you mean that you need to update to the parent of that changeset?

I undid the changeset that removed cdisplay.h and cdisplay.c, but for a 
different (and somewhat less important) reason.  X11 code uses macros 
and C-style casts, but I prefer to avoid those in C++ code and I want 
warnings about them, but I don't want to see warnings from C code that I 
can't change.

But the other problem, of having a global function called panic in a 
system header file that conflicts with Octave's panic function is more 
serious and a better reason to keep them separate.

I added a comment about the cast warnings but I'll also add an 
additional note about the function conflict.

jwe