Re: Best approach to error() code in __glpk__.cc?

[John W. Eaton]

On 12/21/2015 11:40 AM, Rik wrote:
> All,
>
> Is anyone familiar enough with the __glpk__ code to say what should happen
> in the following case?
>
> -- __glpk__.cc:175 --
> if (save_pb)
>    {
>      static char tmp[] = "outpb.lp";
>      if (glp_write_lp (lp, NULL, tmp) != 0)
>        {
>          // FIXME: This doesn't work anymore now that error does not return.
>          //        Should longjmp just be deleted?
>          error ("__glpk__: unable to write problem");
>          longjmp (mark, -1);
>        }
>    }
> -- End Code --
>
> I added the FIXME note.  It seems like we could either:
>
> 1) Delete longjmp because it is no longer reachable
> 2) Downgrade the error() to warning() and preserve the call to longjmp
> 3) ??? Alternative solution ???

I'm not sure what the purpose was, but it doesn't look right to me now. 
 If it was for cleanup, then it should probably be using unwind_protect 
in some way.  I'll take a look at it.

jwe