Re: gplot.txt

[Ben Abbott]

> On Mar 7, 2016, at 8:23 PM, Ben Abbott <address@hidden> wrote:
> 
>> On Mar 7, 2016, at 2:31 PM, Rik <address@hidden> wrote:
>> 
>> Ben, Dan, Lachlan,
>> 
>> I checked in this cset
>> http://hg.savannah.gnu.org/hgweb/octave/rev/9f7282acc30f to resolve the
>> segfaults with speye on Mac platforms.
>> 
>> I made the minimum fix necessary: removing the use of the OCTAVE_NORETURN
>> attribute in a single instance and adding a useless return statement to the
>> previously decorated function in order to suppress the compilation
>> warning.  If further problems develop then we should take the other tack
>> and explicitly distinguish between GCC and clang in the macros that test
>> for GCC.
>> 
>> Cheers,
>> Rik
> 
> Hi Rik,
> 
> This NORETURN stuff is outside my comfort zone. While I started out skeptical 
> of the idea of only fixing this one case, I am happy to report that I’ve 
> competed a build with no crashes. Its been weeks since that happened (I 
> typically encounter several crashes as the docs are built). So although I’ll 
> need to do more testing, my initial impression is positive.
> 
> I’ll try “make check” and report back.
> 
> Ben

Summary:

  PASS     13841
  FAIL        28
  XFAIL       26
  SKIPPED     64

No seg-faults during “make check”!

Rik & Dan, thanks for the effort. I looks like all is working as it should!

Ben