Re: Octave on windows testing

[John W. Eaton]

On 03/10/2016 11:47 AM, Doug Stewart wrote:

>  >> pkg install -forge struct
> In file included from
> C:\Octave\Octave-4.1.0+\include\octave-4.1.0+\octave\../oct
> ave/Array.h:38:0,
>                   from
> C:\Octave\Octave-4.1.0+\include\octave-4.1.0+\octave\../oct
> ave/boolMatrix.h:29,
>                   from
> C:\Octave\Octave-4.1.0+\include\octave-4.1.0+\octave\../oct
> ave/mx-base.h:34,
>                   from
> C:\Octave\Octave-4.1.0+\include\octave-4.1.0+\octave\../oct
> ave/Matrix.h:32,
>                   from
> C:\Octave\Octave-4.1.0+\include\octave-4.1.0+\octave\../oct
> ave/oct.h:30,
>                   from error-helpers.cc:20:
> C:\Octave\Octave-4.1.0+\include\octave-4.1.0+\octave\../octave/idx-vector.h:68:55
> : error: 'unique_ptr' in namespace 'std' does not name a type
>     template <typename T, typename D> friend class std::unique_ptr;
>                                                         ^
> make: *** [error-helpers.o] Error 1
> make: Entering directory `/tmp/oct-Rg2MEu/struct-1.0.12/src'
> CXX=g++ CXXFLAGS="-g -O2"
> C:/Octave/Octave-4.1.0+/bin/mkoctfile-4.1.0+.exe -c err
> or-helpers.cc
> make: Leaving directory `/tmp/oct-Rg2MEu/struct-1.0.12/src'

Why is the struct package overriding the values of CXX and CXXFLAGS?  I 
think it should just use the default values set in mkoctfile.  If a user 
wants to override them, they still can as mkoctfile looks for values of 
CXX and CXXFLAGS in the environment.  But if they are not set in the 
environment, then I don't think the struct package makefile should set them.

jwe