[patch #8972] Adding a demo to ode23 and ode45

[Carlo de Falco]

Follow-up Comment #1, patch #8972 (project octave):

Dear Francesco,

Thanks for the contribution.

A few comments on the submitted patch:

1 - the submitted file contains two changesets concatenated
    into one single file. while this is possible to handle by
    mercurial "hg import", there is no reason to split such a 
    simple change into two separate changesets.

2 - There is no need (and it gives no advantage) to initialize
    to 0 the variables you use for collecting the output of 
    odexx.

3 - Rather than setting both relative and absolute tolerance 
    to the same value it makes more sense to disable the check 
    on AbsTol completely (by setting AbsTol = 0, but see 
    bug #47654 ) and only use RelTol.

4 - Coding style guidelines mandate that comments and commit
    messages be written in imperative form, i.e., instead of
    "Adding a demo to ode23 ...", use "Add a demo to ode23 ..."

5 - As the solution of your benchmark problem is converging to 0
    relative error is a more appropriate measure than absolute 
    error in this case

6 - It is easier to visualize the order from the loglog-plot
    if you normalize the reference slope lines wrt 
    (h.^order/err(end))

7 - Use consistent style for string quoting
    
I made the changes described above and pushed your change.
While looking at this, I notice bug #47654 , could you please
provide a fix for that bug, too?

 

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?8972>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/