Re: external fonts in octave.css

[Mike Miller]

On Wed, Jun 29, 2016 at 00:35:26 +0200, Oliver Heimlich wrote:
> On 28.06.2016 22:16, Oliver Heimlich wrote:
> > Am 28. Juni 2016 21:14:53 MESZ, schrieb Mike Miller <address@hidden>:
> >> Oliver and all,
> >>
> >> The css @font-face declarations in octave.css seem to always download
> >> external fonts when I view octave.html locally, even when I have the
> >> correct fonts installed locally. The attached patch fixes this for me
> >> by
> >> adding a full specification for each of the variants of the two fonts
> >> used.
> >>
> >> I don't know my way around css very well, so asking for review. Does
> >> this look acceptable to you?
> > 
> > Hi Mike,
> > 
> > Looks good to me. Actualy, I am not sure whether the old src-local 
> > directive was 100% correct.
> > 
> > Maybe you could also remove the old local() part, but it shouldn't be 
> > harmful to leave it in.
> > 
> > 
> > Oliver
> > 
> 
> According to my research [1], you may drop the original local()
> directives, but should add additional local() directives with the fonts'
> postscript names, which are as follows:
> 
> RobotoCondensed-Bold
> RobotoCondensed-BoldItalic
> RobotoCondensed-Italic
> RobotoCondensed-Regular
> 
> FantasqueSansMono-Bold
> FantasqueSansMono-BoldItalic
> FantasqueSansMono-Regular
> FantasqueSansMono-Italic
> 
> The postscript names alone work for me locally, as do the display names
> introduced by your patch. The old local() directives don't work on my
> system and should be removed entirely.

Thanks, fixed as suggested:

  http://hg.savannah.gnu.org/hgweb/octave/rev/02216516bbfe

-- 
mike