Re: GSL in octave

[Julien Bect]

Le 19/07/2016 à 04:09, Susi Lehtola a écrit :

On 07/18/2016 02:03 PM, Julien Bect wrote:

I have pushed most of your changes to the OF repo.  You will notice that
I have folded several of your changesets into one for clarity. Perhaps
should you restart now from a fresh clone of the OF repo.

What do you mean by "most"?

Most, really.  I haven't pushed (yet) a few minor things:
 * your changes to DESCRIPTION -> we'll change that when release approaches
 * your changes to the test files (loading package at the begining) -> shouldn't we turn them into real unit tests?
 * changes to the cleaning rule in Makefile -> I'll look into this later, perhaps should we call src/Makefile clean recursively?

Since my previous email, I have pushed all your recent changesets and added a few of my own.

I again had to fold some of your changesets for clarity.  When you have several consecutive changesets that address the same logical change (typically, you realize that you forgot to commit something, or you discover that you made a typo) please don't leave them like them.  Instead, fold them using hg's mq extension.  Of course, you have to do that *before* you push to the public repo (i.e., the changesets must be in "draft" phase).

It seems that there is something wrong with your latest changes to legendre_sphPlm_array.cc (see log below).

@++
Julien



gsl/src$ make
/bin/bash buildgsl_sf.sh
mkoctfile -DHAVE_OCTAVE_40 -v  coupling_3j.cc -lgsl
g++ -c -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -I/usr/include/octave-4.0.3/octave/.. -I/usr/include/octave-4.0.3/octave -I/usr/include/hdf5/serial -I/usr/include/mpi -pthread -fopenmp -g -O2 -fstack-protector-strong -Wformat -Werror=format-security    -DHAVE_OCTAVE_40 coupling_3j.cc -o coupling_3j.o
g++ -I/usr/include/octave-4.0.3/octave/.. -I/usr/include/octave-4.0.3/octave -I/usr/include/hdf5/serial -I/usr/include/mpi -pthread -fopenmp -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -shared -Wl,-Bsymbolic  -o coupling_3j.oct  coupling_3j.o   -lgsl -L/usr/lib/x86_64-linux-gnu/octave/4.0.3 -L/usr/lib/x86_64-linux-gnu -loctinterp -loctave -Wl,-z,relro 
mkoctfile -DHAVE_OCTAVE_40 -v  coupling_6j.cc -lgsl
g++ -c -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -I/usr/include/octave-4.0.3/octave/.. -I/usr/include/octave-4.0.3/octave -I/usr/include/hdf5/serial -I/usr/include/mpi -pthread -fopenmp -g -O2 -fstack-protector-strong -Wformat -Werror=format-security    -DHAVE_OCTAVE_40 coupling_6j.cc -o coupling_6j.o
g++ -I/usr/include/octave-4.0.3/octave/.. -I/usr/include/octave-4.0.3/octave -I/usr/include/hdf5/serial -I/usr/include/mpi -pthread -fopenmp -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -shared -Wl,-Bsymbolic  -o coupling_6j.oct  coupling_6j.o   -lgsl -L/usr/lib/x86_64-linux-gnu/octave/4.0.3 -L/usr/lib/x86_64-linux-gnu -loctinterp -loctave -Wl,-z,relro 
mkoctfile -DHAVE_OCTAVE_40 -v  coupling_9j.cc -lgsl
g++ -c -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -I/usr/include/octave-4.0.3/octave/.. -I/usr/include/octave-4.0.3/octave -I/usr/include/hdf5/serial -I/usr/include/mpi -pthread -fopenmp -g -O2 -fstack-protector-strong -Wformat -Werror=format-security    -DHAVE_OCTAVE_40 coupling_9j.cc -o coupling_9j.o
g++ -I/usr/include/octave-4.0.3/octave/.. -I/usr/include/octave-4.0.3/octave -I/usr/include/hdf5/serial -I/usr/include/mpi -pthread -fopenmp -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -shared -Wl,-Bsymbolic  -o coupling_9j.oct  coupling_9j.o   -lgsl -L/usr/lib/x86_64-linux-gnu/octave/4.0.3 -L/usr/lib/x86_64-linux-gnu -loctinterp -loctave -Wl,-z,relro 
mkoctfile -DHAVE_OCTAVE_40 -v  legendre_sphPlm_array.cc -lgsl
g++ -c -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -I/usr/include/octave-4.0.3/octave/.. -I/usr/include/octave-4.0.3/octave -I/usr/include/hdf5/serial -I/usr/include/mpi -pthread -fopenmp -g -O2 -fstack-protector-strong -Wformat -Werror=format-security    -DHAVE_OCTAVE_40 legendre_sphPlm_array.cc -o legendre_sphPlm_array.o
In file included from /usr/include/octave-4.0.3/octave/../octave/defun-dld.h:30:0,
                 from /usr/include/octave-4.0.3/octave/../octave/oct.h:36,
                 from legendre_sphPlm_array.cc:20:
legendre_sphPlm_array.cc: In function ‘octave_function* Glegendre_array(const octave_shlib&, bool)’:
legendre_sphPlm_array.cc:84:42: warning: unknown escape sequence: '\l'
 DEFUN_DLD(legendre_array, args, nargout, "\
                                          ^
/usr/include/octave-4.0.3/octave/../octave/defun-int.h:112:83: note: in definition of macro ‘DEFINE_FUNX_INSTALLER_FUN’
         octave_dld_function *fcn = octave_dld_function::create (fname, shl, name, doc); \
                                                                                   ^
/usr/include/octave-4.0.3/octave/../octave/defun-dld.h:61:3: note: in expansion of macro ‘DEFINE_FUN_INSTALLER_FUN’
   DEFINE_FUN_INSTALLER_FUN (name, doc) \
   ^
legendre_sphPlm_array.cc:84:1: note: in expansion of macro ‘DEFUN_DLD’
 DEFUN_DLD(legendre_array, args, nargout, "\
 ^
legendre_sphPlm_array.cc:84:42: warning: unknown escape sequence: '\l'
 DEFUN_DLD(legendre_array, args, nargout, "\
                                          ^
/usr/include/octave-4.0.3/octave/../octave/defun-int.h:112:83: note: in definition of macro ‘DEFINE_FUNX_INSTALLER_FUN’
         octave_dld_function *fcn = octave_dld_function::create (fname, shl, name, doc); \
                                                                                   ^
/usr/include/octave-4.0.3/octave/../octave/defun-dld.h:61:3: note: in expansion of macro ‘DEFINE_FUN_INSTALLER_FUN’
   DEFINE_FUN_INSTALLER_FUN (name, doc) \
   ^
legendre_sphPlm_array.cc:84:1: note: in expansion of macro ‘DEFUN_DLD’
 DEFUN_DLD(legendre_array, args, nargout, "\
 ^
legendre_sphPlm_array.cc:84:42: warning: unknown escape sequence: '\l'
 DEFUN_DLD(legendre_array, args, nargout, "\
                                          ^
/usr/include/octave-4.0.3/octave/../octave/defun-int.h:112:83: note: in definition of macro ‘DEFINE_FUNX_INSTALLER_FUN’
         octave_dld_function *fcn = octave_dld_function::create (fname, shl, name, doc); \
                                                                                   ^
/usr/include/octave-4.0.3/octave/../octave/defun-dld.h:61:3: note: in expansion of macro ‘DEFINE_FUN_INSTALLER_FUN’
   DEFINE_FUN_INSTALLER_FUN (name, doc) \
   ^
legendre_sphPlm_array.cc:84:1: note: in expansion of macro ‘DEFUN_DLD’
 DEFUN_DLD(legendre_array, args, nargout, "\
 ^
legendre_sphPlm_array.cc:84:42: warning: unknown escape sequence: '\l'
 DEFUN_DLD(legendre_array, args, nargout, "\
                                          ^
/usr/include/octave-4.0.3/octave/../octave/defun-int.h:112:83: note: in definition of macro ‘DEFINE_FUNX_INSTALLER_FUN’
         octave_dld_function *fcn = octave_dld_function::create (fname, shl, name, doc); \
                                                                                   ^
/usr/include/octave-4.0.3/octave/../octave/defun-dld.h:61:3: note: in expansion of macro ‘DEFINE_FUN_INSTALLER_FUN’
   DEFINE_FUN_INSTALLER_FUN (name, doc) \
   ^
legendre_sphPlm_array.cc:84:1: note: in expansion of macro ‘DEFUN_DLD’
 DEFUN_DLD(legendre_array, args, nargout, "\
 ^
legendre_sphPlm_array.cc: In function ‘octave_value_list Flegendre_array(const octave_value_list&, int)’:
legendre_sphPlm_array.cc:148:69: error: invalid conversion from ‘int’ to ‘gsl_sf_legendre_t’ [-fpermissive]
     gsl_sf_legendre_array_e (norm, lmax, x, csphase, y.fortran_vec());
                                                                     ^
In file included from /usr/include/gsl/gsl_sf.h:28:0,
                 from legendre_sphPlm_array.cc:21:
/usr/include/gsl/gsl_sf_legendre.h:325:5: note:   initializing argument 1 of ‘int gsl_sf_legendre_array_e(gsl_sf_legendre_t, size_t, double, double, double*)’
 int gsl_sf_legendre_array_e(const gsl_sf_legendre_t norm,
     ^
Makefile:20 : la recette pour la cible « legendre_sphPlm_array.oct » a échouée
make: *** [legendre_sphPlm_array.oct] Erreur 1