RE: [mxe-octave : dev] bbaeaed0c584 (patch for windows ) octave-gui.cc cannot be complied

[JohnD]

> 
> Message: 2
> Date: Thu, 21 Jul 2016 16:00:30 +0900 (JST)
> From: Tatsuro MATSUOKA <address@hidden>
> To: "address@hidden" <address@hidden>
> Subject: [mxe-octave : dev] bbaeaed0c584 (patch for windows )
>       octave-gui.cc   cannot be complied
> Message-ID: <address@hidden>
> Content-Type: text/plain; charset=iso-8859-1
> 
> I have cloned the recent repo (bbaeaed0c584) on my ubuntu 14.04 amd64 with
> gcc-5.3.0.
> ./bootstrap, make all, make dist (The build on Ubuntu has no problem).
> Resulted octave
> 
> Also I have updated mxe-octave.
> 
> Revision bbaeaed0c584
> 
> set AppUserModelId for application in Windows (bug #47527)
> 
> * libgui/src/octave-gui.cc:
> ? (set_win_app_id): new function
> ? (gui_application::start_gui_p): add call to set_win_app_id in windows
> 
> 
> Results
> 
> /home/tatsuro/work/octave/mxe-octave/mxe-octave-dev-w64/tmp-default-
> octave/octave-4.1.0+/libgui/src/octave-gui.cc: In function 'void
> set_win_app_id()':
> /home/tatsuro/work/octave/mxe-octave/mxe-octave-dev-w64/tmp-default-
> octave/octave-4.1.0+/libgui/src/octave-gui.cc:72:27: error: expected ')'
before
> '*' token
> ? ?typedef HRESULT (WINAPI *SETCURRENTAPPID)(PCWSTR AppID);
> ? ? ? ? ? ? ? ? ? ? ? ? ? ?^
> /home/tatsuro/work/octave/mxe-octave/mxe-octave-dev-w64/tmp-default-
> octave/octave-4.1.0+/libgui/src/octave-gui.cc:73:3: error: 'HMODULE' was
not
> declared in this scope
> ? ?HMODULE hShell = LoadLibrary ("shell32.dll");
> ? ?^
> /home/tatsuro/work/octave/mxe-octave/mxe-octave-dev-w64/tmp-default-
> octave/octave-4.1.0+/libgui/src/octave-gui.cc:74:7: error: 'hShell' was
not
> declared in this scope
> ? ?if (hShell != NULL)
> ? ? ? ?^
> /home/tatsuro/work/octave/mxe-octave/mxe-octave-dev-w64/tmp-default-
> octave/octave-4.1.0+/libgui/src/octave-gui.cc:76:7: error:
'SETCURRENTAPPID'
> was not declared in this scope
> ? ? ? ?SETCURRENTAPPID pfnSetCurrentProcessExplicitAppUserModelID =
> ? ? ? ?^
> /home/tatsuro/work/octave/mxe-octave/mxe-octave-dev-w64/tmp-default-
> octave/octave-4.1.0+/libgui/src/octave-gui.cc:80:11: error:
> 'pfnSetCurrentProcessExplicitAppUserModelID' was not declared in this
scope
> ? ? ? ?if (pfnSetCurrentProcessExplicitAppUserModelID)
> ? ? ? ? ? ?^
> /home/tatsuro/work/octave/mxe-octave/mxe-octave-dev-w64/tmp-default-
> octave/octave-4.1.0+/libgui/src/octave-gui.cc:84:26: error: 'FreeLibrary'
was
> not declared in this scope
> ? ? ? ?FreeLibrary (hShell);
> ? ? ? ? ? ? ? ? ? ? ? ? ? ^
> make[4]: *** [libgui/src/libgui_src_libgui_src_la-octave-gui.lo] Error 1
> make[4]: Leaving directory `/home/tatsuro/work/octave/mxe-octave/mxe-
> octave-dev-w64/tmp-default-octave/octave-4.1.0+/.build'
> make[3]: *** [install-recursive] Error 1
> make[3]: Leaving directory `/home/tatsuro/work/octave/mxe-octave/mxe-
> octave-dev-w64/tmp-default-octave/octave-4.1.0+/.build'
> make[2]: *** [install] Error 2
> make[2]: Leaving directory `/home/tatsuro/work/octave/mxe-octave/mxe-
> octave-dev-w64/tmp-default-octave/octave-4.1.0+/.build'
> make[1]: *** [build-only-default-octave] Error 2
> make[1]: Leaving directory `/home/tatsuro/work/octave/mxe-octave/mxe-
> octave-dev-w64'
> 
> real130m21.693s
> user119m53.472s
> sys8m40.598s
> 
> Any suggestions?
> 
> Tatsuro
> 


Already fixed by http://hg.savannah.gnu.org/hgweb/octave/rev/ff54e7882863