Re: Do we need "DEFINES=-DWIN32 -DGSL_DLL" in the Makefile of the gsl package?

[Julien Bect]

Le 05/09/2016 à 00:28, Tatsuro MATSUOKA a écrit :
> I misunderstood the situation.
>
> DEFINES=
> ifeq ($(canonical_host_type),i686-pc-msdosmsvc)
> DEFINES=-DWIN32 -DGSL_DLL
> endif
>
>
> The above part is for the msvc (Microsoft Visual C++) build
> for windows and is not related to
> build using gcc (mingw) (cross and native) for windows.
>
> The last official version of octave built by the msvc is 3.6.4.
> However, there are still some people those who use that version.
> I guess that that is for the integration of the Microsoft Visual Studio.
>
> I had tried to build octave on native windows using the mingw build stuff which
> is embedded in octave distribution and gotten successful results.
> Theoretically if one prepare all dependencies are prepared using the msvc,
> octave can be built on windows using the msvc.
>
> Fortunately the above part has no relationship to the current octave for windows
> (built by mxe-octave).
>
> My opinion is that leave the above.
>
> > If they are to be preserved, it would be nice to add a comment explaining
> > why they are useful.
> # The below are preserved for those who attempt to build this package on octave 
> build
> by msvc compiler

Thank you Tatsuro.

The lines that we are currently discussing are in Makefile.in, which is 
turned into a proper Makefile by configure.

Are there really people out that use configure (produced by autoconf) in 
conjunction with MSVC? Is that even possible?

@++
Julien


PS : I have found the following lines in gsl_types.h:

#ifndef GSL_VAR

#ifdef WIN32
#  ifdef GSL_DLL
#    ifdef DLL_EXPORT
#      define GSL_VAR extern __declspec(dllexport)
#    else
#      define GSL_VAR extern __declspec(dllimport)
#    endif
#  else
#    define GSL_VAR extern
#  endif
#else
#  define GSL_VAR extern
#endif