Re: terminals_with_size

[Tatsuro MATSUOKA]

----- Original Message -----

> From: Tatsuro MATSUOKA 
> To: tmacchant Rik 
> Cc: Mike Miller ; John W. Eaton ; Octave-Maintainers 
> Date: 2016/9/16, Fri 12:12
> Subject: Re: terminals_with_size
> 
> ----- Original Message -----
> 
>>  From: "tmacchant
>>  To: Rik ; Tatsuro MATSUOKA 
>>  Cc: Mike Miller ; John W. Eaton ; Octave-Maintainers 
>>  Date: 2016/9/16, Fri 02:34
>>  Subject: Re: terminals_with_size
>> 
>>  --- rik
>>>   On 09/14/2016 06:44 PM, Tatsuro MATSUOKA wrote:
>>>   > ----- Original Message -----
>>>   >
>>>   >> From: Mike Miller 
>>>   > <
>>>   >> To: Rik 
>>>   >> Cc: Tatsuro MATSUOKA ; John W. Eaton ; Octave-Maintainers 
>>>   >> Date: 2016/9/15, Thu 10:17
>>>   >> Subject: Re: terminals_with_size
>>>   >>
>>>   >> I notice that
>>>   >>
>>>   >>   figure ("position", [0, 0, 1000, 200])
>>>   >>
>>>   >> works when using GNUTERM=x11, but not when GNUTERM=qt. This 
> may 
>>  have
>>>   >> something to do with that.
>>>   >
>>>   > In __gnuplot_drawnow__.m
>>>   > Around line 223
>>>   >
>>>   >  if (strcmp (term, "x11") || strcmpi (term, 
>>  "windows"))
>>>   >             ## X11/Windows allows the window to be positioned as 
> well.
>>>   >             units = get (0, "units");
>>>   >             unwind_protect
>>>   >
>>>   > position option is used for x11 and windows.
>>>   > qt supports position option.
>>>   > But wxt supports position option since gnuplot 4.6.4.
>>>   >
>>>   > Now minimum requirement of gnuplot is 4.4 so that if we implement 
> this 
>>  for 
>>>   > wxt terminal, version check is required.
>>>   >
>>>   > Tatsuro
>>>   >
>>>   Tatsuro,
>>> 
>>>   My goal was only to change Octave to require a minimum version of 
> gnuplot 
>>  4.4.
>>> 
>>>   What you propose sounds good, but also less like a bug fix and more 
> like a
>>>   feature request.  It would be nice if Octave took advantage of the
>>>   additional capabilities of wxt that were introduced in 4.6.4.  Why 
>>  don't
>>>   you file a Feature Request on Savannah for this.  The implementation 
> should
>>>   be simple, add another feature in __gnuplot_has_feature__ and then 
> check
>>>   for it in __gnuplot_drawnow__ to see if the positioning code can be 
> used. 
>>>   If you or someone else uploads a changeset there is still time to get 
> this
>>>   feature in for the 4.2.0 release.
>>> 
>>>   --Rik
>>  ok I will do it afterwards.
>>  Thanks
>> 
>>  Tatsuro
> 
> 
> Done
> 
> https://savannah.gnu.org/bugs/?49103
> 
> 
> Tatsuro


Related to this I added explanation to position property of figure function.

https://savannah.gnu.org/bugs/?func=detailitem&item_id=49104


Tatsuro