octave-maintainers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: unnecessary translated strings?


From: Rik
Subject: Re: unnecessary translated strings?
Date: Wed, 21 Sep 2016 10:49:11 -0700

On 09/20/2016 09:00 AM, address@hidden wrote:
Subject:
Re: libgui/src/files-dock-widget.cc: unnecessary translated strings?
From:
"John W. Eaton" <address@hidden>
Date:
09/20/2016 05:34 AM
To:
Andreas Weber <address@hidden>, Octave-Maintainers <address@hidden>
CC:
address@hidden
List-Post:
<mailto:address@hidden>
Content-Transfer-Encoding:
7bit
Precedence:
list
MIME-Version:
1.0
References:
<address@hidden>
In-Reply-To:
<address@hidden>
Message-ID:
<address@hidden>
Content-Type:
text/plain; charset=utf-8; format=flowed
Message:
2

On 09/20/2016 03:59 AM, Andreas Weber wrote:
Dear maintainers,

libgui/src/files-dock-widget.cc:82
  _columns_shown_keys.append (tr ("filesdockwidget/showFileSize"));
  _columns_shown_keys.append (tr ("filesdockwidget/showFileType"));
  _columns_shown_keys.append (tr ("filesdockwidget/showLastModified"));
  _columns_shown_keys.append (tr ("filesdockwidget/showHiddenFiles"));
  _columns_shown_keys.append (tr
("filesdockwidget/useAlternatingRowColors"));

As far as I understand the code, these strings are used as keys and not
visible to the user. So is it save to remove the tr ()?

Yes, if they are translated, then the settings they refer to wouldn't be found?  So I think you are right that they shouldn't be tagged with tr().

jwe

Andy,

Do you want to prepare a cset for that?  I agree this looks like a problem.

--Rik

reply via email to

[Prev in Thread] Current Thread [Next in Thread]