[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: unnecessary translated strings?
|
From: |
Andreas Weber |
|
Subject: |
Re: unnecessary translated strings? |
|
Date: |
Wed, 21 Sep 2016 21:39:52 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.8.0 |
Am 21.09.2016 um 19:49 schrieb Rik:
>> On 09/20/2016 03:59 AM, Andreas Weber wrote:
>>> Dear maintainers,
>>>
>>> libgui/src/files-dock-widget.cc:82
>>> _columns_shown_keys.append (tr ("filesdockwidget/showFileSize"));
>>> _columns_shown_keys.append (tr ("filesdockwidget/showFileType"));
>>> _columns_shown_keys.append (tr ("filesdockwidget/showLastModified"));
>>> _columns_shown_keys.append (tr ("filesdockwidget/showHiddenFiles"));
>>> _columns_shown_keys.append (tr
>>> ("filesdockwidget/useAlternatingRowColors"));
>>>
>>> As far as I understand the code, these strings are used as keys and not
>>> visible to the user. So is it save to remove the tr ()?
>>
>> Yes, if they are translated, then the settings they refer to wouldn't
>> be found? So I think you are right that they shouldn't be tagged with
>> tr().
>>
>> jwe
>
> Andy,
>
> Do you want to prepare a cset for that? I agree this looks like a problem.
Hi Rik,
done: http://hg.savannah.gnu.org/hgweb/octave/rev/88377b002a01
-- Andy