octave-maintainers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: ode csets


From: Rik
Subject: Re: ode csets
Date: Mon, 24 Oct 2016 08:31:27 -0700

On 10/24/2016 03:14 AM, c. wrote:
> On 22 Oct 2016, at 22:18, Rik <address@hidden> wrote:
>> Seems fine to remove.    We don't need BIST tests if there is no underlying
>> code to test.  Can you prepare a changeset to remove the FIXME note as well
>> as this code BIST code below which is never used:
>>
>> %!function jac = fjac (t, y, varargin)  # its Jacobian
>> %!  jac = [0, 1; -1 - 2 * y(1) * y(2), 1 - y(1)^2];
>> %!endfunction
>> %!function jac = fjcc (t, y, varargin)  # sparse type
>> %!  jac = sparse ([0, 1; -1 - 2 * y(1) * y(2), 1 - y(1)^2]);
>> %!endfunction
>>
> --Rik
>
> cset is attached. 
> I left a comment in the tests to explain why those properties are not tested.
> I also made the list of ignored options persistent for performance.
> Can you please review and apply?
Done.  See this cset: http://hg.savannah.gnu.org/hgweb/octave/rev/7eb3f8ec1aed.

One additional thing I did was to alphabetize the options that are
unused/unimplemented.  It hard enough to track which options on which
solvers are unimplemented, but this little bit of organization could help.

--Rik




reply via email to

[Prev in Thread] Current Thread [Next in Thread]