Re: dicom on multiarch (was: Re: [octave:package-releases] #296 dimcom-0.2.0)

[John Donoghue]

On Wed, Feb 22, 2017 at 10:15 PM, John Donoghue <address@hidden> wrote:

On Wed, Feb 22, 2017 at 2:33 PM, Olaf Till <address@hidden> wrote:

On Wed, Feb 22, 2017 at 12:31:12PM -0500, John Donoghue wrote:
> cross compile in mxe works when specifying CMAKE_BINARY with the correct
> toolchain file, similar to other cmake programs buil in mxe.
>
> DO you want to push up your changeset?

I've pushed it.

> I'll bump the dicom version and regenerate a new pakage

You needn't bump the version. We'll just move the tag, this is
possible in mercurial and I can do it for you when pushing the
release. (In the future we'll probably advise to tag only after the
release, or we'll do it ourselves at pushing time if possible.)

I paste the test output, for the case you still want to do something
about it before the release (note that in manual testing, dicomread()
with imshow() worked well). Note that I had to symlink all .cpp files
to .cc for runtests() to work.

Olaf

------ test output follows ----------

octave:7> runtests (".")
Processing files in /home/olaf/devel/octave-forge/package-repositories/all/octave-forge/dicom/src:

  dicomdict.cc ...........................................warning: implicit conversion from scalar to sq_string
 PASS    4/4
  dicominfo.cc ...........................................warning: implicit conversion from scalar to sq_string
Error: In /build/gdcm-2.4.4/Source/DataStructureAndEncodingDefinition/gdcmReader.cxx, line 332, function bool gdcm::Reader::InternalReadCommon(const T_Caller&) [with T_Caller = gdcm::details::DefaultCaller]
No File


 PASS    5/5
Error: In /build/gdcm-2.4.4/Source/DataStructureAndEncodingDefinition/gdcmReader.cxx, line 332, function bool gdcm::Reader::InternalReadCommon(const T_Caller&) [with T_Caller = gdcm::details::DefaultCaller]
No File


  dicomread.cc ........................................... PASS    4/4
  dicomuid.cc ............................................warning: implicit conversion from null_matrix to sq_string
Error: In /build/gdcm-2.4.4/Source/DataStructureAndEncodingDefinition/gdcmReader.cxx, line 332, function bool gdcm::Reader::InternalReadCommon(const T_Caller&) [with T_Caller = gdcm::details::DefaultCaller]
No File


 PASS    5/5
Warning: In /build/gdcm-2.4.4/Source/DataStructureAndEncodingDefinition/gdcmMediaStorage.cxx, line 504, function bool gdcm::MediaStorage::SetFromModality(const gdcm::DataSet&)
Unknown/Unhandle MediaStorage, but Pixel Data element found


  dicomwrite.cc ..........................................warning: implicit conversion from null_matrix to sq_string
warning: implicit conversion from null_matrix to sq_string
Warning: In /build/gdcm-2.4.4/Source/DataStructureAndEncodingDefinition/gdcmMediaStorage.cxx, line 504, function bool gdcm::MediaStorage::SetFromModality(const gdcm::DataSet&)
Unknown/Unhandle MediaStorage, but Pixel Data element found


Warning: In /build/gdcm-2.4.4/Source/DataStructureAndEncodingDefinition/gdcmMediaStorage.cxx, line 504, function bool gdcm::MediaStorage::SetFromModality(const gdcm::DataSet&)
Unknown/Unhandle MediaStorage, but Pixel Data element found


 PASS    7/7
  isdicom.cc ............................................. PASS    3/3

The following files in /home/olaf/devel/octave-forge/package-repositories/all/octave-forge/dicom/src have no tests:

_gendicomdict.cc

--
public key id EAFE0591, e.g. on x-hkp://pool.sks-keyservers.net

I added a check that input was a string on the tests that were showing a warning about not beig given a string

I need to regenerate new tarballs and attach to the release ticket ?