[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: test imfinfo.m typo?
From: |
Carnë Draug |
Subject: |
Re: test imfinfo.m typo? |
Date: |
Wed, 12 Apr 2017 12:42:13 +0100 |
On 12 April 2017 at 00:19, Dmitri A. Sergatskov <address@hidden> wrote:
> test section of octave/scripts/image/imfinfo.m
> has:
> %! warning ("off", "Octave:GraphicsMagic-Quantum-Depth", "local");
>
> Should it be "Magick" ?
>
> Dmitri.
Yes, it should be Magick.
But the typo is not on the imfinfo test, it's in the source for
maybe_initialize_magick which does throw a warning whose ID has Magic
instead of magick [1]. Mea culpa [2].
I am unsure if it's a good idea to fix the typo on warning ID or if we
should keep backwards compatibility. It's pretty recent warning ID I
guess so maybe it won't matter. Anyone has an opinion?
Carnë
[1]
http://hg.savannah.gnu.org/hgweb/octave/file/41639665aa34/libinterp/corefcn/__magick_read__.cc#l800
[2] http://hg.savannah.gnu.org/hgweb/octave/rev/fa68a3f7dd8a