RE: thread model for mxe-octave build

[JohnD]

> -----Original Message-----
> From: John W. Eaton [mailto:address@hidden
> Sent: Monday, February 26, 2018 6:17 PM
> To: JohnD
> Cc: 'Octave Maintainers List'
> Subject: Re: thread model for mxe-octave build
> 
> On 02/26/2018 08:41 AM, John W. Eaton wrote:
> > On 02/25/2018 04:24 PM, JohnD wrote:
> >>>
> >>> As an aside, I think you only reason we needed multilib was so that
> >>> we could also compile nsis in when doing win64.
> >>>
> >>> Not sure if that is still a limitation with newer versions.
> >>>
> >>>
> >>> If I get a chance I will take a look at gcc and nsis as well.
> >>
> >> I played around with it a little and see the same you are seeing with
> >> the incompatible thread line search.
> >> Removing the links and similar efforts either lead to gcc not finding
> >> other files, or still incompatible threads.
> >>
> >> Removing multilib however does compile gcc ok.
> >
> > OK, and yes, I think it was only so we could build NSIS with a 32-bit
> > compiler.  MXE doesn't do multilib, but builds separate compilers for
> > 32- or 64-bit builds.
> 
> I checked in two changes, one to for gcc and one for nsis.  Now gcc builds 
> with -
> -enable-threads=posix and --disable-multilib.  That seems to work.  The other
> change updates to nsis 3.03.  It builds with the 64-bit compiler but when
> running makensis, it fails to find plugins, exiting with the message:
> 
> Plugin not found, cannot call InstallOptions::initDialog Error in macro
> INSTALLOPTIONS_INITDIALOG on macroline 2 Error in macro
> MUI_FUNCTION_WELCOMEPAGE on macroline 48 Error in macro
> MUI_PAGE_WELCOME on macroline 23 Error in script
> "/scratch/jwe/build/mxe-octave-w64-32/dist/octave.nsi"
> on line 68 -- aborting creation process
> /scratch/jwe/build/mxe-octave-w64-32/binary-dist-rules.mk:191: recipe for
> target 'octave-2018-02-26-18-13-installer.exe' failed
> 
> 
> 
> jwe


After reading the newer nsis documentation, there are a few other issues to 
address in the generated nsi script other than just MUI2.nsh
I'll take a look