On Thu, Oct 18, 2018 at 08:50:40 -0700, Rik wrote:
Third thing,
Don't forget to
- mention "-I m4" in ACLOCAL_AMFLAGS in Makefile.am,
I don't see that we are adding '-I m4' anywhere. On the other hand, it
seems to be getting included anyways.
That advice is actually out of date, but probably still relevant for
gnulib users with older versions of Automake. We can safely ignore it
since we require Automake 1.14 or later.
From https://www.gnu.org/software/automake/manual/html_node/Local-Macros.html
| The second possibility, which we do recommend, is to write each macro in
| its own file and gather all these files in a directory. This directory
| is usually called m4/. Then it’s enough to update configure.ac by adding
| a proper call to AC_CONFIG_MACRO_DIRS:
|
| AC_CONFIG_MACRO_DIRS([m4])
|
| aclocal will then take care of automatically adding m4/ to its search
| path for m4 files.
So adding '-I m4' is redundant, and I think if you add it back in,
either Automake or another tool will warn about it being legacy or
unnecessary.