octave-patch-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-patch-tracker] [patch #7874] Renaming unimplemented.m to __unimp


From: Juan Pablo Carbajal
Subject: [Octave-patch-tracker] [patch #7874] Renaming unimplemented.m to __unimplemented__.m
Date: Wed, 24 Oct 2012 22:09:42 +0000
User-agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.4 (KHTML, like Gecko) Chrome/22.0.1229.94 Safari/537.4

URL:
  <http://savannah.gnu.org/patch/?7874>

                 Summary: Renaming unimplemented.m to __unimplemented__.m
                 Project: GNU Octave
            Submitted by: juanpi
            Submitted on: Wed 24 Oct 2012 10:09:41 PM GMT
                Category: None
                Priority: 5 - Normal
                  Status: None
                 Privacy: Public
             Assigned to: None
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any

    _______________________________________________________

Details:

unimplemented.m is mean to be a private function but it has to be visible to
path. To avoid that the user calls this functions unaware of this I rename the
function __unimplemented__ following the instructions by Rik.

At the top level of the repository

$ grep -lr --include="*.m" unimplemented .
./scripts/pkg/private/parse_pkg_idx.m
./scripts/help/unimplemented.m
./scripts/io/importdata.m

However parse_pkg_idx.m importdata.m are false alarms, they do not call
unimplemented.

$ grep -lr --include="*.cc" unimplemented .
./libgui/src/resource-manager.cc
./libinterp/interpfcn/variables.cc

In these two functions it was renamed accordingly




    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Wed 24 Oct 2012 10:09:41 PM GMT  Name: changeset_unimplemented.diff 
Size: 19kB   By: juanpi

<http://savannah.gnu.org/patch/download.php?file_id=26827>

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?7874>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]