[Octave-patch-tracker] [patch #7976] Make PPKG_ADD and PKG_DEL see both m-file and oct-file directories of a package (2nd post)

[Olaf Till]

URL:
  <http://savannah.gnu.org/patch/?7976>

                 Summary: Make PPKG_ADD and PKG_DEL see both m-file and
oct-file directories of a package (2nd post)
                 Project: GNU Octave
            Submitted by: i7tiol
            Submitted on: Wed 20 Mar 2013 11:28:22 PM GMT
                Category: None
                Priority: 5 - Normal
                  Status: None
                 Privacy: Public
             Assigned to: None
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any

    _______________________________________________________

Details:

sorry, in previous post I accidentally hit Enter

Problem:

PKG_ADD and PKG_DEL instructions may need access to both the
architecture-dependent and the architecture-independent directories of a
package. But as yet they are added to or removed from the path sequentielly,
thereby separately calling PKG_ADD or PKG_DEL, respectively. In 'pkg build'
they were even (added/removed) separately for each directory by
generate_lookfor_cache.m/gen_doc_cache.m.

This recently caused problems for the database package in 'pkg build'.
Reportedly there were also problems with other packages due to it. These
problems have been worked around in the packages. But the fix in Octave is not
difficult:

The first patch slightly modifies load-path.cc/h to make 'addpath' call the
hook for the PKG_ADDs only after all argument directories are added (similarly
as the ::do_set method already did it), and correspondingly to 'rmpath'.

The second patch changes some functions called by pkg.m to make use of the
feature in the first path by always calling addpath and rmpath once for all
directories.

I made a testpackage with PKG_ADD and PKG_DEL instructions as described above
which yielded errors for 'pkg build', 'pkg unload', and 'pkg uninstall', and
no errors with the patches. (testpackage not attached)

Olaf




    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Wed 20 Mar 2013 11:28:22 PM GMT  Name: addpath-rmpath.changeset  Size:
7kB   By: i7tiol

<http://savannah.gnu.org/patch/download.php?file_id=27643>
-------------------------------------------------------
Date: Wed 20 Mar 2013 11:28:22 PM GMT  Name: pkg-addpath-rmpath.changeset 
Size: 7kB   By: i7tiol

<http://savannah.gnu.org/patch/download.php?file_id=27644>

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?7976>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/