[Octave-patch-tracker] [patch #8119] Allow variable tolerance and improve error messages for assert.m script

[Rik]

Follow-up Comment #11, patch #8119 (project octave):

This is getting there.  I can see a few more improvements.

1) Instead of simply saying the dimensions don't match we could actually list
them.  Sample format would be "1x3x5".  The following code will create this
format.


dimstr = sprintf ("%dx", size (cond));
dimstr(end) = []; # remove trailing 'x'


2) Absolute error uses the expression "Exceeds abs tol 0 by ..." while
relative tolerance uses "Max rel err %g exceeds tol %g".  They should both use
the same format whatever it is.

3) Multi-dimensional arrays aren't handled properly.


x = zeros (2,2,3);
y = x;
y(1,2,3) = 1;
assert (x,y)
error: ASSERT errors for:  assert (x,y)

  Location  |  Observed  |  Expected  |  Reason
   [1,6]          0            1         Exceeds abs tol 0 by 1


It's kind of lame, but I think you can use sub2ind to do this.


erridx = find (x != y);  
if (any (erridx))
  sz = size (x);
  nd = ndims (x);
  subs = cell (1, nd);
  for idx = erridx(:).'
    [subs{:}] = ind2sub (sz, idx);
    loc = ['(' sprintf("%d,", subs{:}) ];
    loc(end) = ')';
    ... print location and error ...
  endfor
endif




    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?8119>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/