[Octave-patch-tracker] [patch #8363] Agora Patch For Bundle Upload

[Jordi Gutiérrez Hermoso]

Update of patch #8363 (project octave):

                  Status:             In Progress => Invalid                
             Open/Closed:                    Open => Closed                 

    _______________________________________________________

Follow-up Comment #6:

I am sorry to say this, and I don't know how to say this in a nicer way, so I
won't be nice: this patch is sheer nonsense, unless I'm much mistaken. I'm
trying to be charitable and figure out how could you possibly think that this
patch is correct, but it seems to me that either you fail to grasp the most
basic fundamental concepts of Python and Django programming or else I do.

You first left in the patch the os.chmod call which is what this patch was
explicitly supposed to not do. Then you imported the tempfile module, which
has mkdtemp as a member, but you never call tempfile.mkdtemp, but instead you
seem to think that it should be a member function of a Bundle object. But even
if there were some deep Django magic that monkeypatched Bundle objects by
giving them all functions of all modules that you imported as member
functions, You furthermore only patch this in the views.py file, completely
neglecting to patch the corresponding calls to Bundle.get_temp_path in
tasks.py. Fine, this could be an oversight, but the easier thing to do would
be to modify the function Bundle.get_temp_path instead of its calling
locations. Finally, at no point do you handle the the cleanup of the temporary
directories that each invocation of tempfile.mkdtemp makes.

Worst of all, you never admitted any ignorance in any of the things you were
doing. It's OK to not know things. That's what we're all here for, learning,
but it's terrible and horrible and dishonest to not know and not admit that
you don't know.

It doesn't seem to me that you have at all the necessary skills to work on
Python and Django. I recommend you spend a year acquiring these skills and try
again next year.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?8363>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/