[Octave-patch-tracker] [patch #8386] Fixed up "find" function with templates and fourth parameter

[John W. Eaton]

Follow-up Comment #2, patch #8386 (project octave):

Since the extra outputs were undocumented and I couldn't find any uses in
Octave or Octave Forge, I suppose it would be OK to simply remove them instead
of deprecating, warning, then deleting a few releases from now.

I'm not convinced that the additional fourth input argument is needed. 
Reshaping is cheap, and Matlab doesn't have this option, does it?  Other
functions don't have this option, so why should find?

Could you please separate the addition of the fourth argument from the other
patch and submit two separate patches?

It would also be helpful if you could follow the prevailing coding style
(primarily the GNU coding style, plus there are a few other tips here:
http://www.gnu.org/software/octave/doc/interpreter/C_002b_002b-Sources.html#C_002b_002b-Sources).
 We also try to avoid CamelCase.

I think the reason that you didn't find a "min" function in the Octave sources
is because there is one in the C++ standard library, defined in <algorithm>. 
Is there some reason that won't work in this context?


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?8386>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/