octave-patch-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-patch-tracker] [patch #8495] signal package: goertzel function


From: Mike Miller
Subject: [Octave-patch-tracker] [patch #8495] signal package: goertzel function
Date: Fri, 30 Jan 2015 22:35:30 +0000
User-agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/40.0.2214.91 Safari/537.36

Update of patch #8495 (project octave):

                  Status:                    None => Need Info              
             Assigned to:                    None => mtmiller               
                 Summary:          signal package => signal package: goertzel
function

    _______________________________________________________

Follow-up Comment #1:

Thanks for your patch submission. Sorry for the delay in taking a look at it.

Would you mind putting your full name in the copyright line of the source
file? It would be preferable to credit the file to someone's real name if
possible.

Would you be able to adjust the code to use Octave's coding style? See
http://www.gnu.org/prep/standards/standards.html#Formatting and
http://www.gnu.org/software/octave/doc/interpreter/C_002b_002b-Sources.html.

Would you be able to provide some test cases for the algorithm, in Octave's
%!test format? This would help ensure that the function works correctly and
continues to provide the right answers on all systems going forward.

This function can still be added to the signal package if you are not able to
do any of these, but it would help speed things up if the file is made closer
to being ready for inclusion.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?8495>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]