[Octave-patch-tracker] [patch #8006] New marker class to maintain breakpoints and position in modified files

[Dan Sebald]

Follow-up Comment #12, patch #8006 (project octave):

Sorry, I didn't see your post until now.

I tried your updated patch and fixed one rejected hunk in
libgui/src/m-editor/file-editor-tab.h  I tested on a function by moving some
breakpoints and then saving.  The behavior is still as designed.  I see the
added window inquiring if breakpoints should be saved.

The only question I have (comparing the two diff files in Meld) is that you
found no need for the directory and function name when setting the breakpoint,
i.e., 


-  bp_info info (_file_name, line+1);
+  bp_info info (_file_name, line);


as opposed to


-  bp_info info (_file_name, dir, function_name, line+1);
+  bp_info info (_file_name, dir, function_name, line);


Is that extra information needed to resolve files of the same name?  Or
perhaps _file_name is now full path file name?  It's been a while, and I'm
trying to jog my memory.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?8006>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/