[Octave-patch-tracker] [patch #8832] Code Sprint topic #6. Come corefcn

[Andreas Weber]

Follow-up Comment #4, patch #8832 (project octave):

Hm, this patch need a thoroughly review. It doesn't even compile and I bet
"make check" would show many problems.

Some examples:

colloc.cc:
-  retval(3) = q;
-  retval(2) = B;
-  retval(1) = A;
-  retval(0) = r;
-
-  return retval;
+  return ov (r, A, B, q);
<verbatim>
Typo ov -> ovl

And may switch statements with fall through weren't considered.

@José: Can you please fix your patches? Perhaps it would be better to create
a patch per file? I think this makes it easier
to review and apply them.

Thank you, Andy

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?8832>

_______________________________________________
  Nachricht gesendet von/durch Savannah
  http://savannah.gnu.org/