octave-patch-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-patch-tracker] [patch #9065] octave::math::min and max template


From: Carnë Draug
Subject: [Octave-patch-tracker] [patch #9065] octave::math::min and max template ignore isnan
Date: Tue, 2 Aug 2016 12:42:18 +0000 (UTC)
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Firefox/45.0

Follow-up Comment #4, patch #9065 (project octave):

> Why do you need or care about long double? I omitted those because they were
not used in Octave, nor do I expect them to be.

If liboctave is not meant to be used with types other than double, float, and
octave_int's then this is not a problem (and this patch only reduces a bit of
code duplication).

But aren't we moving in the direction of making this a C++ library more useful
by other projects? I think should be considering other types and defining this
operations better so it's clear what min and max are meant to compute for
types we don't know about, and the requirements on those types.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?9065>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]