[Octave-patch-tracker] [patch #9148] Added some BIST test for isinteger() in libinterp/corefcn/data.cc

[Mike Miller]

Follow-up Comment #1, patch #9148 (project octave):

This patch applies cleanly and the tests are written mostly correctly. Some
changes are needed before it can be applied:

* prefer double quoted strings to single quotes whenever possible
* when a function returns a true or false value, assert should be called with
only one argument instead of comparing it to "true" or "false" (there are
numerous examples of this in existing unit tests)
* follow the commit message guildelines
(http://wiki.octave.org/Commit_message_guidelines)



    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?9148>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/