octave-patch-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-patch-tracker] [patch #8656] Variable Editor (expanded from Patc


From: Philip Nienhuis
Subject: [Octave-patch-tracker] [patch #8656] Variable Editor (expanded from Patch #8316)
Date: Wed, 12 Jul 2017 15:24:23 -0400 (EDT)
User-agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:49.0) Gecko/20100101 Firefox/49.0 SeaMonkey/2.46

Follow-up Comment #52, patch #8656 (project octave):

Hey John that is very kind of you.... Thank you very much.

Does your attention for this patch mean that you may want to include it in the
development version at some time in the near future? That would be great.


I did already update the patch locally to the 4.3.0+ state of last weekend but
on Tuesday I hit new liboctave/util/action-container.h changes that needed a
bit more attention than the 30 minutes or so I usually have available on
weekday evenings. So you have fixed those, great.

As to comment #50 (that's where I mentioned the pointer style / error catching
style changes, not comment #49), I wrote they are still *lacking*.
Yet I did change just a few pointer style occurrences (a la the changes that
Rik made). I think a clever search/replace would fix the rest -  AFAIU Rik did
the same thing.

As to error catching (the code/style changes you made 1 - 1.5 years ago): I'm
too unsure about my C++ skills to pursue that. But I think there aren't that
many occurrences of that in the patch.

The patch by Michael Barnes (I just kept it compatible with dev Octave) still
needs attention. 
Copy/paste from external programs (e.g., LibreOffice) only works on Linux and
is transposed; and maybe even limited to a 2xN or Nx2 size array, I'm unsure.
The option to automatically adapt column width to variable size should be
removed - Octave will take ages to calculate the optimum column width for each
change in the variable.
Character strings are shown as char arrays.
And I've been searching for a place to assess the class of the
variables-to-be-shown to be able to avoid structs, Java and classdef objects
for the time being (as they won't work or even hang or crash Octave when
opened in the variable editor).


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?8656>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]