[Octave-patch-tracker] [patch #9494] Patches for polygon2patch & joinPolygns

[Philip Nienhuis]

Follow-up Comment #5, patch #9494 (project octave):

@JuanPi:

A few things.

1. After the lenghty discussion about where the polygon functions should live
we decided on the geometry package.
What I didn't expect was that you would rename them ("polygonClip" etc.),
where I figured the Matlab-comaptible names & options would be used straight
away.
Well, fine :-)
So then I thought the intention was to keep your naming scheme in geometry but
put Matlab-compatible wrappers in the mapping pkg that would call the actual
workhorses in the geometry package.
Now it turns out that the Matlab-compatible wrappers are hosted in the
geometry package as well.
Well, fine too :-)


2. Comparing your and mine tree
Only polyjoin and ispolycw overlap.

polyjoin.m:
- yours only accepts column vectors; got some tests
- mine accepts (& returns) row vectors or column vectors, similar to input
dimension, and also Nx2 or N3 matrices; no tests yet

ispolycw.m:
- yours only accepts column vectors, is based on polygonArea
- mine accepts row & column vectors + Nx2 or Nx3 arrays; is based on clipper

polybool.m:
- yours: N/A
- mine: implements all of matlabs options and is based on clipper (in
geometry). Needs a demo

- polysplit, poly2cw, ispolyccw:
- yours: present, only accept column vectors
- mine: N/A

So each version (yours or mine) has some pros and cons. I think it might be
good to combine them. If you want I can have a go at that.

Matlab accepts column or row vectors anywhere; AFAICS most of the functions in
your repo only accept column vectors.
I'd like most of these functions to accept row and column vectors, or Nx2 (XY)
or Nx3 (XYZ) arrays (and where applicable return row and column vectors or
arrays depending on input).


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?9494>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/