[Octave-patch-tracker] [patch #9448] image package: new function imfindcircles.m

[Carnë Draug]

Follow-up Comment #3, patch #9448 (project octave):

I have made a bunch of changes to the code with

https://bitbucket.org/carandraug/octave-image/commits/ebbdb577c767290764a186930e51b5e178ec72e8

the changes seem like a lot but the actual computations are pretty much the
same.  The main change that looks so difficult to interpret on a diff is the
separation of the long function into subfunctions for:

* the accumulation / voting
* estimate centers from the accumulator
* estimate radii

Order than hopefully making things clear, it also handles the destruction of
no longer required varibales which should also make it use less memory. Other
than the reordering of the code to split into subfunctions, the only main
change was the non-initialization of the accumulator because it's initialized
by accumuarray.

I have joined a bunch of assert blocks taht didn't actually checked the return
values. If they are only being used to check that the function does not error,
then %!test is enough

Let me know if you have any question on the changes I made.  I will merge them
if there's none.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?9448>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/