octave-patch-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-patch-tracker] [patch #9587] [Octave Forge] (Signal) New functio


From: Mike Miller
Subject: [Octave-patch-tracker] [patch #9587] [Octave Forge] (Signal) New function: db2pow convert db value to its power value
Date: Mon, 12 Mar 2018 14:17:21 -0400 (EDT)
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:58.0) Gecko/20100101 Firefox/58.0

Follow-up Comment #2, patch #9587 (project octave):

Thank you for your submissions for db2pow and pow2db. These functions are
needed in the signal package and have not yet been implemented. The code looks
mostly correct and the functions are doing what they should be doing.

I will have some further suggestions and style improvements, but I encourage
you to try reading some existing Octave code, especially in the Octave code
tree itself, to look for ways to make your code adhere to the Octave coding
standards better. Feel free to ping me in a few days if you don't have any
changes of your own and haven't heard from me yet.

I would much prefer that you license your functions under the GPLv3 or later,
this is the standard Octave license. I would also prefer to see your full name
on the Copyright line. and in the mercurial commit log.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?9587>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]