[Octave-patch-tracker] [patch #8506] [octave forge] (signal) taylorwin: new function

[Mike Miller]

Update of patch #8506 (project octave):

                Category:                    None => Forge : new function   
                  Status:             In Progress => Postponed              
                 Summary: signal package: add the taylorwin function =>
[octave forge] (signal) taylorwin: new function

    _______________________________________________________

Follow-up Comment #5:

Sorry for the very long delay. I have reviewed the latest patch here (file
#31986).

The function still needs some formatting work, in the code, the doc strings,
and the comments.

The functions a_constant and b_constant don't really need to be separated out.
The other helper functions may be useful but they are written in an
unnecessarily obtuse style.

I wouldn't be surprised if the for loop at the end of the function could be
simplified and vectorized.

It would be helpful if the series of test cases written at the end of the
function were actual %!test blocks.

I will come back to this and work on it some more, but help with any or all of
these improvements would be welcome.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?8506>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/