octave-patch-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-patch-tracker] [patch #9265] [octave forge] (signal) isstable: n


From: Mike Miller
Subject: [Octave-patch-tracker] [patch #9265] [octave forge] (signal) isstable: new function
Date: Fri, 30 Mar 2018 16:36:05 -0400 (EDT)
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:59.0) Gecko/20100101 Firefox/59.0

Update of patch #9265 (project octave):

                  Status:                    None => Need Info              

    _______________________________________________________

Follow-up Comment #1:

Thank you for your work on this function so far.

The function works for me, looks fairly Matlab compatible, and includes unit
tests that all pass. Very good work.

The coding style mostly conforms to the Octave coding style, but could use
some small improvements. Octave always includes a space between the function
name and the parenthesized argument list. The function doc string should be
written in Texinfo format. And some more input validation could be done to
ensure the arguments are correct before they are used.

I can help clean some of these things up if you don't have time or interest in
working on this. Let me know if you would like to update the function file.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?9265>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]