octave-patch-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-patch-tracker] [patch #10102] [octave forge] (statistics) Add ne


From: Nicholas Jankowski
Subject: [Octave-patch-tracker] [patch #10102] [octave forge] (statistics) Add new 'missing' functions: missing, ismissing, rmmissing, standardizeMissing, fillmissing
Date: Fri, 18 Mar 2022 17:17:05 -0400 (EDT)

Follow-up Comment #22, patch #10102 (project octave):

just uploading a partial implementation of fillmissing attached. let it sit
for a while, but as suspected all of the different method options, including
different handling of middle-versus-end missing values made this a bit more
convoluted. Also, thought I could just mass most of the methods off to interp1
(since the methods seem drawn from interp1), only to find out interp1 fails
when there's only 1 data point in that column for some methods while
fillmissing doesn't. Oh, octave also still doesn't have a makima
implementation. when it does this will work, but currently i just have interp1
issuing the error so nothing has to change when it gets added. that could
probably be cleaned up.

anyway, the helptext is currently complete for eventhing that should get
finished, and that don't rely on currently unimplemented classes. all of the
property-value pairs are implemented, (samplepoints, endvalues,
missinglocations, maxgap), all of the standard 'methods' are implemented. if i
changed the error handling, the way I did it could expand the 'endvalues'
handling to include all options independently of whats' done for the rest of
the array, extending the function a bit beyond what matlab's does. may look at
that at the end.

what's still missing is just the moving window methods and the fill-function
method. 

Once those are done i'll consider this complete (but far from optimized) for
Octave's current class-set.  lots of code could probably move into
subfunctions, but lately we've notice a lot of function call overhead I was
trying to avoid, in addition to being lazy about looking for repeat code. lots
of BISTs for all of the different option combinations. I kept finding
exceptions so kept adding. some of the redundant ones could be trimmed later.


m-file attached for anyone needing this function in partial form before i get
around to finishing it.

(file #53002)

    _______________________________________________________

Additional Item Attachment:

File name: fillmissing.m                  Size:63 KB
    <https://file.savannah.gnu.org/file/fillmissing.m?file_id=53002>



    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/patch/?10102>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]