[Pan-devel] Some notes

[free pro]

Hi,

1. there is some code that displays "save as" dialog if 
post is large enough. That is confusing, because some ppl 
inline pix, there is no need to save anything. 
header-pane.cc, is_mediumish etc.

2. seems like g_mime_init() is not called (gmime 3). I get 
SEGV when decoding subject header.

4. post-ui.cc(points 4-7). GMIME_ADDRESS_TYPE_FROM instead 
of SENDER header.

5. g_mime_message_set_subject (msg, cpch, 
charset.c_str()); without charset arguments it chooses 
"best fit" charset, which is formally ok, but causes 
problems for some other ppl who handle utf8 only.

6. posting is now broken, because _hidden_headers has 
"content-type" and "content-transfer-encoding" headers, 
which causes duplicate headers.

7. there is no way to suppress user-agent header. Could it 
be off by default? _prefs.get_flag (USER_AGENT_PREFS_KEY, 
false)

8. starting with some previous release PAN started to 
duplicate headers in body view. I think this fixed it, but 
I doubt it was proper thing to do:

diff --git a/pan/usenet-utils/mime-utils.cc 
b/pan/usenet-utils/mime-utils.cc
index 135f469..20f1206 100644
--- a/pan/usenet-utils/mime-utils.cc
+++ b/pan/usenet-utils/mime-utils.cc
@@ -1215,7 +1215,7 @@ mime :: construct_message 
(GMimeStream    ** istreams,
       } else
       {
 #endif
-          g_mime_message_set_mime_part(messages[i], 
part);
+          //g_mime_message_set_mime_part(messages[i], 
part);
       }
     }