[Pan-users] 0.12.94 crash in new user startup (Was: ANN: 0.12.94)

[Charles Kerr]

On Mon, Aug 12, 2002 at 07:18:26PM +0200, Lars Bamberger wrote:
> Charles Kerr wrote:
> > 
> > What version of glib do you have installed?
> 
> I have glib 1.2.10 and glib 2.0.4. The configure script reports:
> 
> > checking for glib-2.0 >= 2.0.4
> >     gobject-2.0 >= 2.0.4
> >     gthread-2.0 >= 2.0.4... yes
> > 
> 
> Do you want me to upgrade to glib 2.0.6 to verify that it's an glib problem?

Yes, but before you do that, try this patch.
I'd be surprised if g_strstrip chokes on a NULL pointer,
but it looks like that's what's happening...
and if that's not what's happening, then the two g_message
lines will give us more information.

cheers,
Charles

Index: dialog-newuser.c
===================================================================
RCS file: /cvs/gnome/pan/pan/dialogs/dialog-newuser.c,v
retrieving revision 1.37
retrieving revision 1.38
diff -u -u -r1.37 -r1.38
--- dialog-newuser.c    4 Aug 2002 23:51:00 -0000       1.37
+++ dialog-newuser.c    12 Aug 2002 17:20:31 -0000      1.38
@@ -154,14 +154,16 @@
        
        if (!email) {
                email = pan_config_get_string ("/Pan/User/Email");
-               g_strstrip (email);
+               g_message ("email: [%s]", email ? email : "(Null)");
+               if (email != NULL)
+                       g_strstrip (email);
                if (!is_nonempty_string (email))
                        replace_gstr (&email, NULL);
        }
 
        if (!email) {
                email = g_strdup (g_getenv ("EMAIL"));
-               g_strstrip (email);
+               g_message ("email: [%s]", email ? email : "(Null)");
+               if (email != NULL)
+                       g_strstrip (email);
                if (!is_nonempty_string (email))
                        replace_gstr (&email, NULL);
        }