Re: [Pan-users] Pan/0.139 - threading issue [solved - maybe]

[Dave]

On Monday 30 September 2013 11:57:35 Duncan wrote:
> Duncan posted on Sun, 29 Sep 2013 11:39:04 +0000 as excerpted:
> > OK, bug finally filed.
> > 
> > gmime 2.6.16-2.6.18 split references headers in the wrong place, 2.6.15
> > works fine
> > 
> > https://bugzilla.gnome.org/show_bug.cgi?id=709031
> 
> OK, the bug is (or should be) fixed post in current git, post 2.6.18, so
> the fix should be in 2.6.19.  2.6.16-2.6.18 should be the final affected
> version range, 2.6.15- and 2.6.19+ should be fine.
> 
> In the fix, Jeff S. fixed gmime to treat references headers special, much
> like gmime was already doing for the message-id header, which it doesn't
> fold, but since references contains multiple message-ids, he decided to
> play it conservative and follow the RFC SHOULDs (not just the MUSTs),
> folding only between IDs, not internal to them.
> 
> That is assuming the fix works as intended and this and further posts get
> threaded correctly, since I'm running the patches now, but a quick look
> around at references headers (including that kmail one) that were broken
> with the bad version, says it's working. =:^)
> 
> If you want to apply the patches, there are two (watch the wrap, I'm not
> going to bother turning off pan's wrapping for this and I guess you
> probably know what it does to long URLs):
> 
> https://git.gnome.org/browse/gmime/commit/?
> id=a248cc044c6ad55505939363aa858c930867a014
> 
> ... and ...
> 
> https://git.gnome.org/browse/gmime/commit/?
> id=1373f11f9b3ecdbfb58a70a742506f3f6d5c57d8
> 
> You can download the patches directly from there using the "(patch)" link
> on each one.  Apply a248cc04 first as I think 1373f11f depends on it (tho
> I didn't actually check, I just set them up to apply that way here).  And
> you'll need to edit the first one (a248cc04) to remove the changelog diff
> from the patch, as there were further additions to the changelog between
> 2.6.18 and the patch.

I just dropped a note to the maintainer of the FreeBSD port so that might well 
get the patch applied (or the port will just "pull" the correct version 
anyway) before I get the chance to even try that :-)

> Other than that edit, the patches apply cleanly to 2.6.18, which builds
> fine with them, and based on my quick look about after restarting pan,
> the problem does seem to have been fixed. =:^)
> 
> > (I'm sick...)
> 
> (Feeling MUCH better now.  Fever broke and I started sweating oh, about
> 12 hours ago now, and I'm well on my way to normal functionality. =:^)
> 
> (Now to rest an hour or so before work... I agreed to open today since I
> was sick and didn't close yesterday, but I slept most of the day and had
> this and other stuff to finish that I didn't get done while I was sick,
> so I've been up most of the night.  Filing the bug with gentoo to have
> them patch current versions since upstream has a fix applied now... can
> wait...)

That's good to hear.  The only reason I'm posting today is I've  been waiting 
in for the new company car to be delivered.  It just arrived so I have to get 
all my stuff in and go do some work now.  That means a late finish so I'm 
hoping patches will have propogated to ports before I have to do it myself. 
:-)